c# - IEnumerable parser class design -

i'm creating class can read dicom file. binary file filled lot of objects. want create solid class can this. i've designed following.

using system; using system.collections.generic; using system.linq; using system.text; using system.io;  namespace medicom {     public class ddocument : ienumerable<ddataelement>     {         /// <summary>         /// creates new ddocument file.         /// </summary>         /// <param name="path">the path of file load </param>         /// <returns>an ddocument contains dicom information file</returns>         public static ddocument load(string path)         {             return ddocument.load(new filestream(path, filemode.open));          }          /// <summary>         /// creates new xdocument instance using specified stream.         /// </summary>         /// <param name="stream">the stream contains dicom information.</param>         /// <returns>an ddocument contains dicom information stream.</returns>         public static ddocument load(stream stream)         {             //logic here read whole stream , list<ddataelement> data data         }          /// <summary>         /// gets or sets list metainformation containing ddataelements         /// </summary>         public list<ddataelement> data         {             get;             set;         }          /// <summary>         /// returns enumerator can used iterate through ddocument         /// </summary>         /// <returns>an ienumerator can used iterate through ddocument</returns>         public ienumerator<ddataelement> getenumerator()         {             foreach (ddataelement dataelement in data)             {                 yield return dataelement;             }         }     } } 

i wanted know think of it. there changes make in class?

two things:

first, should close filestream when you're done it:

public static ddocument load(string path) {     using(filestream fs = new filestream(path, filemode.open)) {         return ddocument.load(fs);      } } 

second, list has ienumerable! should use it!

public ienumerator<ddataelement> getenumerator() {     return (ienumerator<ddataelement>)data.getenumerator(); }