c++ - Infinite Loops and Early Return Statements -

i have simple console application outputs menu , waits user input. after performing appropriate action, entire process repeats. program exits when specific string entered. implemented infinite loop , return statement:

int main() {     while (true)     {         outputmenu();          string userchoice;         cin >> userchoice;          // ...          if (userchoice == "exit") return 0;     } } 

according teacher, it's bad practice use infinite loop , hack way out of return statement. suggests following:

int main() {     bool shouldexit = false;     while (!shouldexit)     {         outputmenu();          string userchoice;         cin >> userchoice;          // ...          if (userchoice == "exit") shouldexit = true;     }      return 0; } 

• is bad idea use infinite loop , return statement?
• if so, there technical reason or bad practice?

this might 1 of rare cases do...while appropriate. avoid adding boolean state variables unless genuinely make code clearer.

int main() {     string userchoice;         {         outputmenu();          cin >> userchoice;          // ...      } while (userchoice != "exit"); } 

however, user input loop make function returns whether or not input successful. stands code end in infinite loop if cin closes.

e.g.

bool getnonexitinput( std::istream& in, std::string& s ) {     outputmenu();     in >> s;      return in.good() && s != "exit"; }   int main() {     std::string userchoice;      while (getnonexitinput(std::cin, userchoice))     {         // ...     } }